Workflow Color Styles - all grey

airzoink · October 6, 2016, 10:09am

I have assigned colors for my Purchase Order Approval workflow but it seems that it is not working. The Workflow States do change but the colors do not (just grey). Can anyone check on this and give me advise on what to do? Thanks!

–Aaron

Sangram · October 6, 2016, 11:05am

@airzoink

from where you assigned colors ?[quote=“airzoink, post:1, topic:16615”]
I have assigned colors for my Purchase Order Approval workflow but it seems that it is not working.
[/quote]

Check indicator.js

github.com

frappe/frappe/blob/develop/frappe/public/js/frappe/model/indicator.js#L47




			if(locals["Workflow State"][value] && locals["Workflow State"][value].style) {
				var colour = {
					"Success": "green",
					"Warning": "orange",
					"Danger": "red",
					"Primary": "blue",
				}[locals["Workflow State"][value].style];
			}
			if(!colour) colour = "darkgrey";


			return [__(value), colour, workflow_fieldname + ',=,' + value];
		}
	}


	// draft if document is submittable
	if(is_submittable && doc.docstatus==0 && !settings.has_indicator_for_draft) {
		return [__("Draft"), "red", "docstatus,=,0"];
	}


	// cancelled

airzoink · October 6, 2016, 11:28am

@Sangram

From Workflow State->Style. I did not touch any code. It was working fine before i did updates. I also changed the Workflow State Field to workflow_states. I previously changed the labels from my old records and the labels worked fine. Just the color that are not changing.

applepipe · October 6, 2016, 12:10pm

Hello,

I’m having the same issue here on v7.1 develop, all the status are shown in grey color, no code was modified, and it was working fine before this week updates like @airzoink said.

Sangram · October 6, 2016, 12:17pm

@applepipe and @airzoink

indicator color for your workflow state depends on your style given for that state.

Style represents the button color: Success - Green, Danger - Red, Inverse - Black, Primary - Dark Blue, Info - Light Blue, Warning - Orange

why ?

applepipe · October 6, 2016, 12:24pm

@Sangram

It is configured as you described, in this case Primary:

But in list view this is the result:

I did not change the name or anything related to workflow.

Sangram · October 6, 2016, 12:38pm

@applepipe

Check style gave for workflow state

add styles and check

applepipe · October 6, 2016, 2:04pm

It was configured as Primary like the screenshot in my previous post, changed to success but no luck, no matter what style I choose the status is always in grey.

Sangram · October 6, 2016, 2:07pm

@applepipe

It changes indicator color, not status color.

applepipe · October 6, 2016, 2:11pm

@Sangram
I used the wrong term, where you read status, you can read indicator.

airzoink · October 6, 2016, 2:26pm

So that my label indicators would update.

Mukesh_Variyani · October 7, 2016, 7:15am

We were also facing same issue, I have created issue on github, please leave comment on that if you are also facing same issue.

johnskywalker · October 7, 2016, 8:15am

@nabinhait changes caused this problem, I have reverted it and created a pull request

Sean_Mark_Mira · October 7, 2016, 8:24am

Great! I have seen the changes. It solved the problem. Thank you so much. @johnskywalker

nabinhait · October 7, 2016, 12:22pm

fixed in latest release via https://github.com/frappe/frappe/commit/0d8528486b5666ffb864b9506ad8a8780b44100a

applepipe · October 10, 2016, 11:20am

Thank you, it solved the problem!

H_nh_Nguy_n · June 24, 2022, 3:46pm

do you know how can i customize more color for workflow state?