RFQ Save Error after editing

Flat-Duck · February 21, 2018, 8:48am

I edited the RFQ doc Type To match my work needs when i try to save the doc after filling data i was interrupted by this error

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/form/save.py", line 22, in savedocs
    doc.save()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 256, in save
    return self._save(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 279, in _save
    self.insert()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 245, in insert
    self.run_post_save_methods()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 827, in run_post_save_methods
    self.run_method("on_update")
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 702, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 924, in composer
    return composed(self, method, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 909, in runner
    add_to_return_value(self, f(self, method, *args, **kwargs))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/communication/feed.py", line 26, in update_feed
    feed = doc.get_feed()
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/controllers/buying_controller.py", line 27, in get_feed
    return _("From {0} | {1} {2}").format(self.supplier_name, self.currency,
AttributeError: 'RequestforQuotation' object has no attribute 'currency'

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 57, in application
    response = frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 22, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 53, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 923, in call
    return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/form/save.py", line 22, in savedocs
    doc.save()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 256, in save
    return self._save(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 279, in _save
    self.insert()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 245, in insert
    self.run_post_save_methods()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 827, in run_post_save_methods
    self.run_method("on_update")
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 702, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 924, in composer
    return composed(self, method, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 909, in runner
    add_to_return_value(self, f(self, method, *args, **kwargs))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/communication/feed.py", line 26, in update_feed
    feed = doc.get_feed()
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/controllers/buying_controller.py", line 27, in get_feed
    return _("From {0} | {1} {2}").format(self.supplier_name, self.currency,
AttributeError: 'RequestforQuotation' object has no attribute 'currency'

nabinhait · February 21, 2018, 9:50am

Seems like you have removed Currency field, which is used in the code.

nabinhait · February 21, 2018, 9:51am

We never recommend to delete any standard field. You can hide fields if you don’t need it.

Flat-Duck · February 21, 2018, 10:10am

i didn’t delete any thing i only add a few fields

nabinhait · February 21, 2018, 10:13am

Ok. Have you added a custom field named “supplier_name”?

Flat-Duck · February 21, 2018, 10:23am

Yes at first i added it, but it didn’t update so changed it to “supplier_full_name”

nabinhait · February 21, 2018, 10:26am

System is still getting ‘supplier_name’ value somehow, which is causing the error.

github.com

frappe/erpnext/blob/master/erpnext/controllers/buying_controller.py#L29


      
          
          
class BuyingController(StockController):
          	def __setup__(self):
          		if hasattr(self, "taxes"):
          			self.flags.print_taxes_with_zero_amount = cint(frappe.db.get_single_value("Print Settings",
          				 "print_taxes_with_zero_amount"))
          			self.flags.show_inclusive_tax_in_print = self.is_inclusive_tax()
          
          
			self.print_templates = {
          				"total": "templates/print_formats/includes/total.html",
          				"taxes": "templates/print_formats/includes/taxes.html"
          			}
          
          
	def get_feed(self):
          		if self.get("supplier_name"):
          			return _("From {0} | {1} {2}").format(self.supplier_name, self.currency,
          				self.grand_total)
          
          
	def validate(self):
          		super(BuyingController, self).validate()
          		if getattr(self, "supplier", None) and not self.supplier_name:

Flat-Duck · February 21, 2018, 10:37am

Thank you very much, I’ll look into it

Flat-Duck · February 28, 2018, 2:12pm

Hello, there I’ve been trying the whole week nothing worked for me only i want to do is to change the RFQ document multi-Supplier to one supplier with contact that’s

I tried to hide the supplier table add the supplier link then i got the error.

Please how can achieve the one supplier approach.

Thanks