ERPNext Foundation ERPNext Cloud User Manual Blog Discuss Frappé* Donate

"leave without pay" variable spelling mistake in salary register


#1

leave without pay variable spelling mistake in salary register python file of master branch. There is just an o missing in leave_without_pay creating error in the salary register.


#2

Please post the traceback or a screenshot of the error message to give the context thanks!


#3

it simply does not show the leaves without pay in the salary register report as the variable name is incorrect.


#4

Tropicalrambler submitted that fix on develop on Feb 15 https://github.com/frappe/erpnext/pull/16670/files

master has not been fixed as of 11.1.36

frappe@ubuntu:~/frappe-bench$ bench version
/home/frappe/frappe-bench/env/local/lib/python2.7/site-packages/requests/init.py:80: RequestsDependencyWarning: urllib3 (1.23) or chardet (3.0.4) doesn’t match a supported version!
RequestsDependencyWarning)
erpnext 11.1.36
frappe 11.1.33
frappe@ubuntu:~/frappe-bench$ find . -name ‘*.py’ | xargs grep leave_with
./apps/erpnext/erpnext/hr/report/salary_register/salary_register.py: ss.company, ss.start_date, ss.end_date, ss.leave_withut_pay, ss.payment_days]
./apps/erpnext/erpnext/hr/report/salary_register/salary_register.py: if not ss.leave_withut_pay == None: columns[9] = columns[9].replace(’-1’,‘130’)
./apps/erpnext/erpnext/hr/doctype/salary_slip/salary_slip.py: self.get_leave_details(lwp = self.leave_without_pay)
./apps/erpnext/erpnext/hr/doctype/salary_slip/salary_slip.py: self.leave_without_pay = lwp

For fixes to v11, my rough understanding these are as requested or required by paid support users, for example subscribers on erpnext.com

On the PR you may want to request that master be patched with the fix and to upvote the PR