Is this normal behaviour of frappe.utils.getdate()?

hiimkhaled · September 29, 2022, 6:35am

Somehow frappe.utils.getdate() changing date format and returning completely a different date of the input. dd-mm-yyyy is set in my ERPNext Setting.

Is this normal? how can I retrieve the weekday name then?

Thanks and Regards
Khaled

amadhaji · September 29, 2022, 8:34am

what I know is frappe.utils.getdate always use yyyy-mm-dd format

github.com

frappe/frappe/blob/1b4bfc57d8e2bced64fbf08526315719c8bfabdb/frappe/utils/data.py#L53


      
          
          

          
def is_invalid_date_string(date_string):
          	# dateutil parser does not agree with dates like "0001-01-01" or "0000-00-00"
          	return not isinstance(date_string, str) or (
          		(not date_string) or (date_string or "").startswith(("0001-01-01", "0000-00-00"))
          	)
          
          

          
# datetime functions
          def getdate(string_date: Optional[str] = None):
          	"""
          	Converts string date (yyyy-mm-dd) to datetime.date object.
          	If no input is provided, current date is returned.
          	"""
          	from dateutil import parser
          	from dateutil.parser._parser import ParserError
          
          
	if not string_date:
          		return get_datetime().date()
          	if isinstance(string_date, datetime.datetime):

there is frappe.utils.dateutils.parse_date which convert user_format to yyyy-mm-dd

but I guess it doesn’t work in safe_exec from UI

Workaround solution could be:

date_str = "10-12-2021 23:31:39"
date_format = frappe.db.get_default("date_format") or "yyyy-mm-dd"
date_str = date_str[0:len(date_format)]

dem = "-"
date_format_comp = date_format.split(dem)
if len(date_format_comp) < 3: 
    dem = "."
    date_format_comp = date_format.split(dem)
if len(date_format_comp) < 3: 
    dem = "/"
    date_format_comp = date_format.split(dem)
    
    


yyyy_index = date_format_comp.index("yyyy")
mm_index = date_format_comp.index("mm")
dd_index = date_format_comp.index("dd")
date_list = date_str.split(dem)
date_list = [date_list[yyyy_index], date_list[mm_index], date_list[dd_index]]

date_str = "-".join(date_list)

log(date_str)

date = frappe.utils.getdate(date_str)
day = frappe.utils.get_weekday(date)

log(date)
log(day)