How to block the refresh button in Report?

root13F · July 31, 2018, 7:50am

We have a certain script report that tends to hog a lot of system resources, and it seems that the query is accessing the disk leading to high cpu usage. I wish to have a short term solution till I can fix the MySQL configuration.

Is there a way to block the refresh the button till the query has finished and the report has been rendered ?

magic-overflow · July 31, 2018, 8:43am

I’m assuming you’re on master branch V10. You can disable button in $("button:contains('Refresh')").prop("disabled",true) refresh function and enable refresh button in _refresh function (in callback frappe.call) $("button:contains('Refresh')").prop("disabled",false);.

Edit:
After made change
bench build

github.com

frappe/frappe/blob/288b98ca766cf15e25be63f58d5a251bb9510cd5/frappe/public/js/frappe/views/reports/query_report.js#L378


      
          				}
          			});
          			promises.push(() => {
          				frappe.route_options = null;
          			});
          
          
			return frappe.run_serially(promises);
          		}
          
          
	},
          	refresh: function() {
          		// throttle
          		// stop refresh from being called multiple times (from triggers ?)
          		if (!this.request_refresh) {
          			this.request_refresh = setTimeout(() => {
          				this._refresh();
          				this.request_refresh = null;
          			}, 300);
          		}
          	},
          	_refresh: function() {

pratu16x7 · August 1, 2018, 4:27am

Or you can pass the refresh button object in frappe.call in the btn property. It will disable the button until the call has been executed.

Example:

https://github.com/frappe/erpnext/blob/master/erpnext/hub_node/page/hub/hub.js#L675