Fixture Problem

mehta_akshay · February 13, 2016, 10:03am

Hi,

While Creating and Deploying a Custom App I encountered a Strange Error.

Search Fields should contain valid fieldnames

After digging into this I found that the property_setter.json was being processed before custom_field.json when the fixtures were getting Installed.

So The Solution I came up with was to update the fixtures.py here:

github.com

frappe/frappe/blob/833bae2c77988610c1672d7748b6eaf930af1163/frappe/utils/fixtures.py#L17


      
          from frappe.core.page.data_import_tool.data_import_tool import import_doc, export_json
          
          
def sync_fixtures(app=None):
          	"""Import, overwrite fixtures from `[app]/fixtures`"""
          	if app:
          		apps = [app]
          	else:
          		apps = frappe.get_installed_apps()
          	for app in apps:
          		if os.path.exists(frappe.get_app_path(app, "fixtures")):
          			for fname in os.listdir(frappe.get_app_path(app, "fixtures")):
          				if fname.endswith(".json") or fname.endswith(".csv"):
          					import_doc(frappe.get_app_path(app, "fixtures", fname), ignore_links=True, overwrite=True)
          
          
		import_custom_scripts(app)
          
          
	frappe.db.commit()
          
          
def import_custom_scripts(app):
          	"""Import custom scripts from `[app]/fixtures/custom_scripts`"""
          	if os.path.exists(frappe.get_app_path(app, "fixtures", "custom_scripts")):

I Changed the above with the following:

        fixture_files = sorted(os.listdir(frappe.get_app_path(app, "fixtures")))
        for fname in fixture_files:

Is this a Good Solution? or is there another method to avoid processing property_setter.json before custom_field.json

thanks
Akshay

rmehta · February 15, 2016, 9:41am

Yeah, update property setter after custom field.

@mehta_akshay FYI, I have been following up with @nabinhait on integrating your assets app. Its on my list.

mehta_akshay · February 15, 2016, 10:06am

@rmehta should the fix be included in the main repository ?

thanks of Info & Support

nabinhait · February 18, 2016, 11:52am

@mehta_akshay Yeah, please send a PR