Can't pass rds_db option via helm chart

joshr · September 12, 2022, 11:39pm

Using the official chart (helm/README.md at main · frappe/helm · GitHub), there doesn’t seem to be a way to deploy to RDS without manual fixup. You can set the db type to mariadb but common_site_config.json requires an rds_db option (frappe_docker/new.py at 5121e2710653c8df513e953a21e8d1ee8d3c2bde · frappe/frappe_docker · GitHub) to be set in order to deal with RDS permissions. Is there a way to pass this option through an existing facility (e.g., jobs.configure)?

revant_one · September 13, 2022, 4:01am

No. Send a PR if you add it.

Or generate template of configure bench job, change the bench set-config command and name of job as per need.

github.com

frappe/helm/blob/27cad47f6869a621e80638037c98bacb0e50f74d/erpnext/templates/job-configure-bench.yaml#L46-L52


      
          [[ -f common_site_config.json ]] || echo "{}" > common_site_config.json;
          bench set-config -gp db_port $DB_PORT;
          bench set-config -g db_host $DB_HOST;
          bench set-config -g redis_cache $REDIS_CACHE;
          bench set-config -g redis_queue $REDIS_QUEUE;
          bench set-config -g redis_socketio $REDIS_SOCKETIO;
          bench set-config -gp socketio_port $SOCKETIO_PORT;

joshr · September 13, 2022, 3:42pm

I think I see why it’s not exposed via helm Bench does not currently have a configuration option for rds_db. In its absence, common_site_config.json would have to be manually hacked. I’ve opened rds_db option not configurable via bench · Issue #1371 · frappe/bench · GitHub for this issue. If nothing else, I’d like to get some feedback there regarding implementation: create a dedicated ‘db-environment’ option or just add a new mariadb-rds db-type.

Edit: Nevermind. I didn’t realize how set-config worked. It looks like it will accept arbitary options. Working on a patch now.

joshr · September 14, 2022, 2:03am

https://github.com/frappe/helm/pull/138