You can use custom field in naming series along with YY MM DD option

Chude_Osiegbu · January 10, 2017, 11:01pm

This functionality is great. I wonder though which is should only be applied to naming series. I think with a small change it can also be used to build composite name fields for doctypes. So for example, if I have a doctype with fields X, Y and Z, in addition to the possibility of an auto name .X.-.Y.-.#### I should also be able to have just .X.-.Y.

What do you think?

Regards,
cksgb

kolate_sambhaji · January 11, 2017, 9:32am

@raveslave can you check PO-16-.supplier.-####? if this is working, then check whether you get data in supplier code.

Anyways, you can Skype me at kolate.sambhaji and we can have a look at this problem.

Frappe team developed option to add YY MM DD and I have added option to add custom field in naming series and this is working for us.

kolate_sambhaji · January 11, 2017, 9:33am

@Chude_Osiegbu currently you can use fields present in same doctype only. Its great suggestion to use fields from another doctype.
Can you post issue on github?
I will check this if I can develop this.

Chude_Osiegbu · January 11, 2017, 12:13pm

Hi @kolate_sambhaji ,

Thanks but I meant whether it’s possible to remove the requirement for #### in the auto name rule. Sometimes you want to concatenate fields into the name without appending an auto-incrementing number

Regards,
cksgb

kolate_sambhaji · January 11, 2017, 1:39pm

@Chude_Osiegbu yes you can remove .####

Chude_Osiegbu · January 11, 2017, 1:52pm

Hmm… Will try again. Didn’t seem to work when I tried earlier. Thanks.

raveslave · February 22, 2017, 6:56pm

Hi @kolate_sambhaji

I tested with .supplier. and that works. So not sure what’s going wrong here.
pls help confirm that it’s correctly setup (see the screenshot in my post from Dec 16 above)

best david

kolate_sambhaji · February 23, 2017, 7:05am

Correct syntax is PO-16-.supplier_code.-#### where supplier_code is custom field in Purchase Order.
Make sure supplier code is present before you save PO.

OR

To test feature, you can take supplier code custom field in PO and add supplier code manually in PO.

jof2jc · March 1, 2017, 2:34am

Hi all,

If we use e.g. JV/.YY./.MM./.### and make back-dated entry (posting date is backdated entry) then MM takes always current month

How to make naming series follow posting_date. not server current date

kolate_sambhaji · March 1, 2017, 10:16am

This feature is not available right now, you need to create hardcoded naming series as JV/16/03/.###

hendrik_zeta · March 1, 2017, 11:10am

I have the same problem.
In the quotation I want to use the number QN.YYYY.MM.-.####, Where YYYYMM was taken from the ‘Date’
I have tried it in the quotation and the results are quite satisfactory, when I create a new quote and fill in the ‘Date’ for example, January 1st, 2017, the naming series that is produced is QN201701-0001, but the date on the server is already in March.

In the ‘customize form’ Quotation, add ‘Field’ with the name ‘date_for_series’
Create a custom script for a quote, as follows:

var date_for_series = function(frm){
var ymd = frm.doc.transaction_date;
var yy = ymd.substring(0,4);
var mm = ymd.substring(5,7);
var ym = yy+“”+mm;
frm.set_value(“date_for_series”, ym);
}
frappe.ui.form.on(“Quotation”, “validate”, function(frm) {
date_for_series(frm);
})

3.Create naming_series by name: QN.date_for_series.-.####
Of course there are still some weaknesses.

kolate_sambhaji · March 1, 2017, 5:22pm

@hendrik_zeta sorry for the trouble.

Can you reproduce same in demo account?
https://demo.erpnext.com

You can see YYYY MM is taken from todays date instead on quotation or transaction date.

github.com

frappe/frappe/blob/develop/frappe/model/naming.py#L109


      
          		for count in range(1, 4):
          
          
			def fake_counter(_prefix, digits):
          				# ignore B023: binding `count` is not necessary because
          				# function is evaluated immediately and it can not be done
          				# because of function signature requirement
          				return str(count).zfill(digits)  # noqa: B023
          
          
			generated_names.append(parse_naming_series(self.series, doc=doc, number_generator=fake_counter))
          		return generated_names
          
          
	def update_counter(self, new_count: int) -> None:
          		"""Warning: Incorrectly updating series can result in unusable transactions"""
          		Series = frappe.qb.DocType("Series")
          		prefix = self.get_prefix()
          
          
		# Initialize if not present in DB
          		if frappe.db.get_value("Series", prefix, "name", order_by="name") is None:
          			frappe.qb.into(Series).insert(prefix, 0).columns("name", "current").run()
          
          
		(

hendrik_zeta · March 2, 2017, 1:30am

@kolate_sambhaji I can’t access Setup > Custom Script and Setup > Customize Form in https://demo.erpnext.com

kolate_sambhaji · March 15, 2017, 3:57pm

[quote=“hendrik_zeta, post:31, topic:10865”]
n the quotation I want to use the number QN.YYYY.MM.-.####, Where YYYYMM was taken from the ‘Date’
[/quote]

@hendrik_zeta I am making same thing for one client,
So in Quote I will take it from quotation_date and in sales invoice I will take YYMM from transaction_date.

Can you suggest generic design to add it in customise form and doctype naming series, if this will help, I would like to add it in default erpnext feature

strixaluco · March 18, 2017, 8:59am

Very useful thread, thanks, @kolate_sambhaji.

We want to use naming scheme, which will assign predefined abbreviations instead of full words. E.g. ITEM-2017-03-05-R instead of ITEM-2017-03-Apple-Red, where value Apple is predefined as 05 and value Red is predefined as R.
Is this possible to achieve by custom script, not touching source code?

kolate_sambhaji · March 18, 2017, 1:15pm

@strixaluco yes this is possible using custom script and custom fields, you need to add custom field for abbr. Then using custom script you can set values in abbr.
It will auto pickup in naming series.

Thanks,
Sam

strixaluco · March 21, 2017, 8:23am

Thanks, @kolate_sambhaji and sorry for late reply.

strixaluco · March 22, 2017, 8:10am

It’s a pity, but seems like my understanding of scripting is not enough.

I added two custom fields to Item doctype:


#    label    type      options    

1    Fruit    Select    Apple    
                        Pear     
                        Banana 

2    Color    Select    Yellow  
                        Green   
                        Red

Let’s imagine I’m creating new item selecting Apple as Fruit and Green as Color. Chosen naming scheme is ITEM-YYYY-MM-FRUIT-COLOR, which gives us ITEM-2017-03-Apple-Green in the example.
But what we want is to assign abbreviations as following:


#    label    type      options    abbreviation

1    Fruit    Select    Apple      AP
                        Pear       PR
                        Banana     BN

2    Color    Select    Yellow     01
                        Green      02
                        Red        03

so that the system generates ITEM-2017-03-AP-02 instead.

Can somebody please help us with such script?

JoEz · March 22, 2017, 8:57am

I think u should write a custom script and check selected value, kind of

var fruit_abbreviation

switch(fruit) {
   case "Apple":
      fruit_abbreviation = "AP";
      break;
   case "Pear":
      fruit_abbreviation = "PR";
      break;
   case "Banana":
      fruit_abbreviation = "BN";
      break;
}

then use ITEM-YYYY-MM-FRUIT_ABBREVIATION-COLOR_ABBREVIATION

strixaluco · March 22, 2017, 9:15am

Thanks a lot, @JoEz. I will try, assuming that you meant something like this for our case:

var fruit_abbreviation

switch(fruit) {
   case "Apple":
      fruit_abbreviation = "AP";
      break;
   case "Pear":
      fruit_abbreviation = "PR";
      break;
   case "Banana":
      fruit_abbreviation = "BN";
      break;
}

var color_abbreviation

switch(color) {
   case "Yellow":
      color_abbreviation = "01";
      break;
   case "Green":
      color_abbreviation = "02";
      break;
   case "Red":
      color_abbreviation = "03";
      break;
}