WooCommerce Sales Order as Draft

Corey_Johnson · February 1, 2021, 1:21am

Recently back to ERPNext since overall it has everything I need but I am having an issue with orders from WooCommerce. Not all of the charges (usually tax & freight transfer over properly and I end up with a different order $ Total.

Is there a way to edit or modify the integration so that orders are in Draft status so I can modify if necessary? Right now I have to recreate and then delete the original. Not the end of the world but rather time consuming.

revant_one · February 1, 2021, 1:40am

github.com

frappe/erpnext/blob/77d5f593767bccc064dc853bf6a6e0ebcda891ca/erpnext/erpnext_integrations/connectors/woocommerce_connection.py#L183


      
          	created_date = order.get("date_created").split("T")
          	new_sales_order.transaction_date = created_date[0]
          	delivery_after = woocommerce_settings.delivery_after_days or 7
          	new_sales_order.delivery_date = frappe.utils.add_days(created_date[0], delivery_after)
          
          
	new_sales_order.company = woocommerce_settings.company
          
          
	set_items_in_sales_order(new_sales_order, woocommerce_settings, order, sys_lang)
          	new_sales_order.flags.ignore_mandatory = True
          	new_sales_order.insert()
          	new_sales_order.submit()
          
          
	frappe.db.commit()
          
          
def set_items_in_sales_order(new_sales_order, woocommerce_settings, order, sys_lang):
          	company_abbr = frappe.db.get_value('Company', woocommerce_settings.company, 'abbr')
          
          
	default_warehouse = _("Stores - {0}", sys_lang).format(company_abbr)
          	if not frappe.db.exists("Warehouse", default_warehouse) \
          		and not woocommerce_settings.warehouse:
          		frappe.throw(_("Please set Warehouse in Woocommerce Settings"))

It submits the orders here.

You can add a field in woocommerce settings that flags whether to submit orders and check the value before .submit()

If it works for you then do send a pull request.

Corey_Johnson · February 1, 2021, 2:49am

Well, that was overly simple. Thank you. Probably not the cleanest thing to do but I just commented out the submit line and performed a test. Sales order was created but left in Draft status.

Thank you. Not sure what you mean about a pull request.

173. # new_sales_order.submit()

revant_one · February 1, 2021, 8:09am

This just makes the orders draft for all cases.

It can be done like following:

Woocommerce Settings should have a field is_order_submittable
if frappe.db.get_value('Woocommerce Settings', 'Woocommerce Settings', 'is_order_submittable'): new_sales_order.submit()

Pull request means sending the fix or feature you made into the upstream ERPNext code so that others can also benefit from it.

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request