Why I cant see Links in webforms?

max_morais_dmm · February 16, 2016, 11:48pm

I created a webform based on lead, but I cant see the links fields

rmehta · February 17, 2016, 6:10am

I think Link is converted to “Select”, so if you have Campaigns, they will show up.

max_morais_dmm · February 18, 2016, 10:44pm

@rmehta, no! The form dont show anything in the position of the link field!

max_morais_dmm · February 18, 2016, 10:46pm

Another point, Labels in “Section Breaks” are not included too!

max_morais_dmm · February 19, 2016, 1:49am

github.com

frappe/frappe/blob/632c48ecb13e95ca40a84aa7424a413bce1ed2ee/frappe/templates/generators/web_form.html#L66


      
          		{% if field.description -%}
          		<span class="help-block small">{{ field.description }}</span>
          		{%- endif -%}
          {%- endmacro %}
          
          
{% macro label(field) %}
          		<label for="{{ field.fieldname }}" class="control-label text-muted small">
          				{{ field.label }}</label>
          {% endmacro %}
          
          
{% macro render_field(field) %}
          	{% if field.hidden %}
          	<input type="hidden"
          		name="{{ field.fieldname }}" value="{{ field.default }}">
          	{% elif field.fieldtype == "HTML" and field.options %}
          	<div class="form-group">
          		{{ field.options }}
          	</div>
          	{% elif field.fieldtype in ("Data", "Date", "Datetime") %}
          	<div class="form-group">
          		{{ label(field) }}

This macro dont render a Link!

Any clue to I publish a PR?

rmehta · February 19, 2016, 5:50am

@max_morais_dmm link is included as a Select.

The Select (of type Link) is hidden if there is no permission.

github.com

frappe/frappe/blob/develop/frappe/website/doctype/web_form/web_form.py#L44


      
          			or frappe.flags.in_test
          			or frappe.flags.in_fixtures
          		)
          		if in_user_env and self.is_standard and not frappe.conf.developer_mode:
          			# only published can be changed for standard web forms
          			if self.has_value_changed("published"):
          				published_value = self.published
          				self.reload()
          				self.published = published_value
          			else:
          				frappe.throw(_("You need to be in developer mode to edit a Standard Web Form"))
          
          
		if not frappe.flags.in_import:
          			self.validate_fields()
          
          
	def validate_fields(self):
          		"""Validate all fields are present"""
          		from frappe.model import no_value_fields
          
          
		missing = []
          		meta = frappe.get_meta(self.doc_type)

max_morais_dmm · February 22, 2016, 12:31am

@rmehta, It dont work! https://erp.gogogoshipping.com/quotation, I have 2 links to Country, and the “Guest” user have rights to read

rmehta · February 24, 2016, 5:34am

@max_morais_dmm do you want to debug?

max_morais_dmm · February 24, 2016, 5:56am

@rmehta, I cant debug it!

It’s failling silent! And I dont have access to this server!

ahmad18189 · March 29, 2016, 10:54am

iam facing the same problem
is there issue opened for it ?
anything new about it ?

mostafa · April 12, 2016, 7:55am

@max_morais_dmm Add the following code at generators/web_form.html inside function render_field

you can put it after select checking

{% elif field.fieldtype==“Link” %}

   <select class="form-control" {{ properties(field) }}>
  {% for option in frappe.get_list(field.options.split("\n")[0]) -%}
  <option value="{{ option.name }}"
     {{ 'selected="selected"' if value(field)==option else '' }}>
     {{ option.name }}</option>
  {%- endfor %}

ahmad18189 · April 12, 2016, 7:56am

That is the best answer @rmehta check this out

kolate_sambhaji · September 27, 2017, 3:33pm

Is this fixed for adding linked fields in web pages.

satish_malkar · March 29, 2020, 11:10am

Hello ,
In my doctype i have one link filed …same filed i have to use in web form … so how can i use this in web form …even working is also sames …
can u please help me

Thanks