[Website] [Shopping Cart]

kartik · December 20, 2018, 7:39am

Hello all,
Wanted some clarificatio on possible bug in shopping cart while placing order.

As per intended functionality, on clicking place order in cart, it checks the quantity of stock in the website warehouse and throws an exception message if the quantity of order being placed > quantity of stock in warehouse.
But this is not happening functionally. Exception message is not being thrown and Sales order is being created even if stock in warehouse is less than that of order placed. I found this due to the below linked line.

github.com

frappe/erpnext/blob/master/erpnext/shopping_cart/cart.py#L69


      
          
          
	quotation.flags.ignore_permissions = True
          	quotation.submit()
          
          
	if quotation.quotation_to == 'Lead' and quotation.party_name:
          		# company used to create customer accounts
          		frappe.defaults.set_user_default("company", quotation.company)
          
          
	from erpnext.selling.doctype.quotation.quotation import _make_sales_order
          	sales_order = frappe.get_doc(_make_sales_order(quotation.name, ignore_permissions=True))
          
          
	if not cart_settings.allow_items_not_in_stock:
          		for item in sales_order.get("items"):
          			item.reserved_warehouse, is_stock_item = frappe.db.get_value("Item",
          				item.item_code, ["website_warehouse", "is_stock_item"])
          
          
			if is_stock_item:
          				item_stock = get_qty_in_stock(item.item_code, "website_warehouse")
          				if item.qty > item_stock.stock_qty[0][0]:
          					throw(_("Only {0} in stock for item {1}").format(item_stock.stock_qty[0][0], item.item_code))

What is happening is values are not being correctly assigned to the variables while tuple unpacking because of None, None condition at the end. If we remove that, then it works fine.

Sahil · December 20, 2018, 8:24am

@kartik check may be your negative stock is allowed in setting.

kartik · December 20, 2018, 8:48am

Negative stock is disabled. Still can place order.