V8 update warning *json is missing

I have updated some instance recently, while updating I got following warning

Can anyone please explain why this warning get, also it says /assessment.json is missing, but In erpnext master, there is no doctype Assessment

Warning:

Executing frappe.patches.v7_2.set_in_standard_filter_property #1 in ngse (fa9f0f8c06ade8dd)
/home/frappe/workspace/allhome/frappe-bench/apps/erpnext/erpnext/utilities/doctype/address/address.json missing

/home/frappe/workspace/allhome/frappe-bench/apps/erpnext/erpnext/utilities/doctype/address_template/address_template.json missing
/home/frappe/workspace/allhome/frappe-bench/apps/erpnext/erpnext/schools/doctype/assessment/assessment.json missing
/home/frappe/workspace/allhome/frappe-bench/apps/erpnext/erpnext/buying/doctype/quality_inspection/quality_inspection.json missing
/home/frappe/workspace/allhome/frappe-bench/apps/erpnext/erpnext/schools/doctype/discussion/discussion.json missing
/home/frappe/workspace/allhome/frappe-bench/apps/erpnext/erpnext/accounts/doctype/payment_gateway/payment_gateway.json missing
/home/frappe/workspace/allhome/frappe-bench/apps/erpnext/erpnext/schools/doctype/announcement/announcement.json missing
/home/frappe/workspace/allhome/frappe-bench/apps/erpnext/erpnext/schools/doctype/topic/topic.json missing

erpnext code:
https://github.com/frappe/erpnext/tree/develop/erpnext/schools/doctype

1 Like

As a learning exercise I will try to answer:

  1. The manual says https://frappe.github.io/frappe/user/en/tutorial/models

When a DocType is saved, a new table is created in the database. This table is named as tab[doctype] .

When you create a DocType a new folder is created in the Module and a model JSON file and a controller template in Python are automatically created. When you update the DocType, the JSON model file is updated and whenever bench migrate is executed, it is synced with the database. This makes it easy to propagate schema changes and migrate.

  1. So from this refactoring from v7 to v8

This general code change results
frappe@erpnext:~/frappe-bench$ bench version
erpnext 7.2.18
erpnext_custom 0.0.1
frappe 7.2.14

frappe@erpnext:~/frappe-bench$ find . -name assessment*.*
./apps/erpnext/erpnext/templates/includes/assessment/assessment_row.html
./apps/erpnext/erpnext/schools/doctype/assessment_result/assessment_result.py
./apps/erpnext/erpnext/schools/doctype/assessment_result/assessment_result.json
./apps/erpnext/erpnext/schools/doctype/assessment/assessment.js
./apps/erpnext/erpnext/schools/doctype/assessment/assessment.py
./apps/erpnext/erpnext/schools/doctype/assessment/assessment.json
./apps/erpnext/erpnext/schools/doctype/assessment_group/assessment_group.json
./apps/erpnext/erpnext/schools/doctype/assessment_group/assessment_group.py
./apps/erpnext/erpnext/schools/doctype/assessment_group/assessment_group.js

frappe@erpnext:~/frappe-bench$ bench version
erpnext 8.0.10
frappe 8.0.14

frappe@erpnext:~/frappe-bench$ find . -name assessment*.*
./apps/erpnext/erpnext/public/js/schools/assessment_result_tool.html
./apps/erpnext/erpnext/templates/includes/assessment/assessment_row.html
./apps/erpnext/erpnext/schools/doctype/assessment_result_tool/assessment_result_tool.js
./apps/erpnext/erpnext/schools/doctype/assessment_result_tool/assessment_result_tool.py
./apps/erpnext/erpnext/schools/doctype/assessment_result_tool/assessment_result_tool.json
./apps/erpnext/erpnext/schools/doctype/assessment_result_tool/assessment_result_tool.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_code/assessment_code.json
./apps/erpnext/erpnext/schools/doctype/assessment_code/assessment_code.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_code/assessment_code.js
./apps/erpnext/erpnext/schools/doctype/assessment_code/assessment_code.py
./apps/erpnext/erpnext/schools/doctype/assessment_plan_criteria/assessment_plan_criteria.py
./apps/erpnext/erpnext/schools/doctype/assessment_plan_criteria/assessment_plan_criteria.json
./apps/erpnext/erpnext/schools/doctype/assessment_plan_criteria/assessment_plan_criteria.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_result/assessment_result.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_result/assessment_result.py
./apps/erpnext/erpnext/schools/doctype/assessment_result/assessment_result.js
./apps/erpnext/erpnext/schools/doctype/assessment_result/assessment_result.json
./apps/erpnext/erpnext/schools/doctype/assessment/assessment.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_criteria/assessment_criteria.js
./apps/erpnext/erpnext/schools/doctype/assessment_criteria/assessment_criteria.py
./apps/erpnext/erpnext/schools/doctype/assessment_criteria/assessment_criteria.json
./apps/erpnext/erpnext/schools/doctype/assessment_criteria/assessment_criteria.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_plan/assessment_plan.json
./apps/erpnext/erpnext/schools/doctype/assessment_plan/assessment_plan.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_plan/assessment_plan.py
./apps/erpnext/erpnext/schools/doctype/assessment_plan/assessment_plan.js
./apps/erpnext/erpnext/schools/doctype/assessment_criteria_group/assessment_criteria_group.js
./apps/erpnext/erpnext/schools/doctype/assessment_criteria_group/assessment_criteria_group.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_criteria_group/assessment_criteria_group.py
./apps/erpnext/erpnext/schools/doctype/assessment_criteria_group/assessment_criteria_group.json
./apps/erpnext/erpnext/schools/doctype/assessment_result_detail/assessment_result_detail.py
./apps/erpnext/erpnext/schools/doctype/assessment_result_detail/assessment_result_detail.json
./apps/erpnext/erpnext/schools/doctype/assessment_result_detail/assessment_result_detail.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_group/assessment_group.pyc
./apps/erpnext/erpnext/schools/doctype/assessment_group/assessment_group.json
./apps/erpnext/erpnext/schools/doctype/assessment_group/assessment_group_tree.js
./apps/erpnext/erpnext/schools/doctype/assessment_group/assessment_group.py
./apps/erpnext/erpnext/schools/doctype/assessment_group/assessment_group.js

  1. So with Assessment gone from v8, this db schema change patch runs and warns:
    Executing frappe.patches.v7_2.set_in_standard_filter_property #1 in ngse (fa9f0f8c06ade8dd)
    /home/frappe/workspace/allhome/frappe-bench/apps/erpnext/erpnext/utilities/doctype/address/address.json missing

  2. This is a ‘leftover’ in v8 /apps/erpnext/erpnext/schools/doctype/assessment/assessment.pyc

1 Like

@clarkej Thanks for the explanation.