UOM Conversions In Sales Order

kolate_sambhaji · January 1, 2015, 8:58am

Hi,

We want to implement UOM Conversions Facility in Sales Order, which is allready present in Purchase Order
What is the steps we need to follow? Can I send Pull request for this?

Thanks,
Sambhaji

umair · January 1, 2015, 9:55am

Hello Sambhaji,

That’s great! Please send pull request. We shall review it and then revert. Also provide brief documentation around it, so that we can understand it better.

kolate_sambhaji · January 2, 2015, 2:34pm

Hi,
I have created pull request for UOM conversion.

Balance Stock updated successful as per stock_qty and accounting done as per selling quantity (qty).

I have some difficulty in updating projected quantity.

Can you please review code.
https://github.com/frappe/erpnext/pull/2545

Thanks,

Sambhaji

kolate_sambhaji · January 2, 2015, 2:43pm

Can you please explain this function?
I don’t understand from where ‘reserved_qty’ comes.
What changes I will have to do to fetch correct reserved_qty from selling_controller.py

github.com

frappe/erpnext/blob/develop/erpnext/selling/doctype/sales_order/sales_order.py#L233


      
          		self.update_reserved_qty()
          
          
		frappe.get_doc("Authorization Control").validate_approving_authority(
          			self.doctype, self.company, self.base_grand_total, self
          		)
          		self.update_project()
          		self.update_prevdoc_status("submit")
          
          
		self.update_blanket_order()
          
          
		update_linked_doc(self.doctype, self.name, self.inter_company_order_reference)
          		if self.coupon_code:
          			from erpnext.accounts.doctype.pricing_rule.utils import update_coupon_code_count
          
          
			update_coupon_code_count(self.coupon_code, "used")
          
          
	def on_cancel(self):
          		self.ignore_linked_doctypes = ("GL Entry", "Stock Ledger Entry", "Payment Ledger Entry")
          		super(SalesOrder, self).on_cancel()
          
          
		# Cannot cancel closed SO

kolate_sambhaji · January 14, 2015, 7:56am

Hi Team,
I have successfully completed test cases for pull request #2545
Can you please review the code and merge pull request in version 4.
Kindly give me steps to send pull request for version 5.
Can I merge this branch with version 5 locally and send pull request, or need to develop same feature in version 5?

Thanks
Sambhaji Kolate

rmehta · January 15, 2015, 7:08am

Continuing discussion in pull-request.