Unstable Custom App Version

ALAADIAA · June 3, 2022, 12:05pm

Hi everyone
we are using multitenancy through port and when we publish new version of our custom app we use these steps
git pull
bench build
bench --site all migrate
But the version of the app is unstable sometimes get version and suddenly if I reload I got old version
any clue in this issue?
Update:
I have doubt that may the issue is happed because of a bench bug but I found the only command deal with custom app version in the bench code is bench update in this line

github.com

frappe/bench/blob/593c7b737fb9ce8b9425c2674597879b006a5d5e/bench/utils/bench.py#L398


      
          		pull, patch, build, requirements = True, True, True, True
          
          
	if apps and pull:
          		apps = [app.strip() for app in re.split(",| ", apps) if app]
          	else:
          		apps = []
          
          
	validate_branch()
          
          
	version_upgrade = is_version_upgrade()
          	handle_version_upgrade(version_upgrade, bench_path, force, reset, conf)
          
          
	conf.update({"maintenance_mode": 1, "pause_scheduler": 1})
          	update_config(conf, bench_path=bench_path)
          
          
	if backup:
          		print("Backing up sites...")
          		backup_all_sites(bench_path=bench_path)
          
          
	if pull:
          		print("Updating apps source...")

The wired thing I can not explain that I can not find migrate code in this source code
is our step to upgrade to the new version wrong and should we use bench update in replace of it and where I can read migrate code -BTW I really appreciate open source more after this little experience- ?

revant_one · June 3, 2022, 11:17pm

there are 2 parts to bench.

the source code you’re looking at is for bench.

the migration component of the command is part of frappe framework

https://frappeframework.com/docs/v13/user/en/bench/frappe-commands

github.com

frappe/frappe/blob/6d3f1266000b0e86322f1f9d71f40e9f50dc5e40/frappe/commands/site.py#L396


      
          		user = frappe.get_doc("User", email)
          		user.enabled = 0
          		user.save(ignore_permissions=True)
          		frappe.db.commit()
          
          

          
@click.command("migrate")
          @click.option("--skip-failing", is_flag=True, help="Skip patches that fail to run")
          @click.option("--skip-search-index", is_flag=True, help="Skip search indexing for web documents")
          @pass_context
          def migrate(context, skip_failing=False, skip_search_index=False):
          	"Run patches, sync schema and rebuild files/translations"
          	import re
          
          
	from frappe.migrate import migrate
          
          
	for site in context.sites:
          		print("Migrating", site)
          		frappe.init(site=site)
          		frappe.connect()
          		try:

ALAADIAA · June 4, 2022, 6:14am

thank you @revant_one for your help
I read the code and I saw that migrate doing a lot of things is not in the bench update
do you suggest keeping this flow when updating my app on multitenancy
git pull
bench build
bench --site all migrate
or recommend doing a different one like using bench update to replace pull and build?

revant_one · June 4, 2022, 8:04am

did you try bench update by itself?

it’ll pull the latest code for set branch as part of the process.

ALAADIAA · June 14, 2022, 7:00pm

Thank you @revant_one bench update --apps MycstomApp save my day
but I face wired issue after this command run I found my app name disappear from sites/apps.txt
any idea why this happened?

system · December 11, 2022, 7:00pm

This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.