Time stamp error when updating to 10

Hi,

I am trying to upgrade to v10

when i type bench update

i get this error

Executing erpnext.patches.v8_0.create_domain_docs	#16-05-2017 in my_home-site1 (264f3f61e7a14364)
Traceback (most recent call last):
 File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
   "__main__", fname, loader, pkg_name)
 File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
   exec code in run_globals
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 94, in <module>
   main()
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 18, in main
   click.Group(commands=commands)(prog_name='bench')
 File "/home/erpnext/my_home/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 722, in __call__
   return self.main(*args, **kwargs)
 File "/home/erpnext/my_home/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 697, in main
   rv = self.invoke(ctx)
 File "/home/erpnext/my_home/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
   return _process_result(sub_ctx.command.invoke(sub_ctx))
 File "/home/erpnext/my_home/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
   return _process_result(sub_ctx.command.invoke(sub_ctx))
 File "/home/erpnext/my_home/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 895, in invoke
   return ctx.invoke(self.callback, **ctx.params)
 File "/home/erpnext/my_home/frappe-bench/env/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke
   return callback(*args, **kwargs)
 File "/home/erpnext/my_home/frappe-bench/env/local/lib/python2.7/site-packages/click/decorators.py", line 17, in new_func
   return f(get_current_context(), *args, **kwargs)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/commands/__init__.py", line 24, in _func
   ret = f(frappe._dict(ctx.obj), *args, **kwargs)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/commands/site.py", line 222, in migrate
   migrate(context.verbose, rebuild_website=rebuild_website)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/migrate.py", line 31, in migrate
   frappe.modules.patch_handler.run_all()
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 29, in run_all
   if not run_single(patchmodule = patch):
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 63, in run_single
   return execute_patch(patchmodule, method, methodargs)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 83, in execute_patch
   frappe.get_attr(patchmodule.split()[0] + ".execute")()
 File "/home/erpnext/my_home/frappe-bench/apps/erpnext/erpnext/patches/v8_0/create_domain_docs.py", line 46, in execute
   domain_settings.save(ignore_permissions=True)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 256, in save
   return self._save(*args, **kwargs)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 307, in _save
   self.run_post_save_methods()
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 887, in run_post_save_methods
   self.run_method("on_update")
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 755, in run_method
   out = Document.hook(fn)(self, *args, **kwargs)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 1024, in composer
   return composed(self, method, *args, **kwargs)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 1007, in runner
   add_to_return_value(self, fn(self, *args, **kwargs))
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 749, in <lambda>
   fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/core/doctype/domain_settings/domain_settings.py", line 23, in on_update
   domain.setup_domain()
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/core/doctype/domain/domain.py", line 18, in setup_domain
   self.setup_roles()
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/core/doctype/domain/domain.py", line 73, in setup_roles
   user.save()
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 256, in save
   return self._save(*args, **kwargs)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 286, in _save
   self.check_if_latest()
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/model/document.py", line 630, in check_if_latest
   raise_exception=frappe.TimestampMismatchError)
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/__init__.py", line 309, in msgprint
   _raise_exception()
 File "/home/erpnext/my_home/frappe-bench/apps/frappe/frappe/__init__.py", line 282, in _raise_exception
   raise raise_exception(encode(msg))
frappe.exceptions.TimestampMismatchError: Error: Document has been modified after you have opened it (2018-01-05 11:18:48.861931, 2018-01-05 11:18:49.327124). Please refresh to get the latest document.

so tried this
bench --site ente.site reload-doc Core Doctype Domain
then bench updated

i got the same error as above

then i tried this
bench --site ente.site reload-doc Core Doctype Domain Settings
Error: Got unexpected extra argument (Settings)

and i have 2 custom app installed with this and a remote url is at gitlab

use small case and replace spaces by _:

eg:

bench --site ente.site reload-doc reload-doc core doctype domain_settings

still facing this issue?

@saurabh6790 i tried this but it is not working

any help in this topic

I’m having the same issue. I can’t update to v10 bacause of this.

Migrating testing.****.***
Executing frappe.patches.v9_1.resave_domain_settings in testing.****.*** (5c87c252cdcbf23b)
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 94, in <module>
    main()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 18, in main
    click.Group(commands=commands)(prog_name='bench')
  File "/home/frappe/frappe-bench/env/lib/python2.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/frappe/frappe-bench/env/lib/python2.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/frappe/frappe-bench/env/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/frappe/frappe-bench/env/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/frappe/frappe-bench/env/lib/python2.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/frappe/frappe-bench/env/lib/python2.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/frappe/frappe-bench/env/lib/python2.7/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/commands/__init__.py", line 24, in _func
    ret = f(frappe._dict(ctx.obj), *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/commands/site.py", line 222, in migrate
    migrate(context.verbose, rebuild_website=rebuild_website)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/migrate.py", line 31, in migrate
    frappe.modules.patch_handler.run_all()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 29, in run_all
    if not run_single(patchmodule = patch):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 63, in run_single
    return execute_patch(patchmodule, method, methodargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py", line 83, in execute_patch
    frappe.get_attr(patchmodule.split()[0] + ".execute")()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/patches/v9_1/resave_domain_settings.py", line 10, in execute
    domain.setup_domain()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/domain/domain.py", line 18, in setup_domain
    self.setup_roles()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/domain/domain.py", line 73, in setup_roles
    user.save()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 256, in save
    return self._save(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 286, in _save
    self.check_if_latest()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 630, in check_if_latest
    raise_exception=frappe.TimestampMismatchError)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 309, in msgprint
    _raise_exception()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 282, in _raise_exception
    raise raise_exception(encode(msg))
frappe.exceptions.TimestampMismatchError: Error: Document has been modified after you have opened it (2018-02-21 17:25:01.176223, 2018-02-7:25:01.573641). Please refresh to get the latest document.

So I have a workaround for this.

first, comment out two patches:
vi apps/frappe/frappe/patches.txt
comment out:

#frappe.patches.v9_1.resave_domain_settings
#frappe.patches.v9_1.revert_domain_settings

in frappe-bench/apps/frappe execute

git status
git commit

to add the modified patches.txt into the master.

run bench update - for me this was now sucessful
run bench update --reset
this will remove the commit and the pathes are applied, in my case without problem.

Then I ran into another issue. but this is solved in

@bedo thanks for the support.

I tried your solution but bench update won’t work for me, I had to --reset which removes the changes.

Update: seems to be working now, it’s different for my case I had to comment “erpnext.patches.v8_0.create_domain_docs”