Stock Ledger get_valuation_rate query question?

dj12djdjs · October 4, 2021, 10:09pm

Hello All,

I’m confused reading through the stock_ledger.py get_valuation_rate method. I’m trying to understand why this method takes parameters voucher_type and voucher_no but the SQL condition is checking that the stock ledger does not equal the specified voucher_type and voucher no.

My thought when I read this method name is that it’s purpose is to get the valuation rate for the specified item for the specified voucher. But it does not, it ignores the voucher and just gets the last valuation rate for that item.

Basically I want to know why we want to ignore the specified voucher type and voucher no in the query?

github.com

frappe/erpnext/blob/5c372202d5fb024843fc1b13f843901f832532f7/erpnext/stock/stock_ledger.py#L914-L937


      
          def get_valuation_rate(item_code, warehouse, voucher_type, voucher_no,
          	allow_zero_rate=False, currency=None, company=None, raise_error_if_no_rate=True):
          	# Get valuation rate from last sle for the same item and warehouse
          	if not company:
          		company = erpnext.get_default_company()
          
          
	last_valuation_rate = frappe.db.sql("""select valuation_rate
          		from `tabStock Ledger Entry`
          		where
          			item_code = %s
          			AND warehouse = %s
          			AND valuation_rate >= 0
          			AND NOT (voucher_no = %s AND voucher_type = %s)
          		order by posting_date desc, posting_time desc, name desc limit 1""", (item_code, warehouse, voucher_no, voucher_type))
          
          
	if not last_valuation_rate:
          		# Get valuation rate from last sle for the item against any warehouse
          		last_valuation_rate = frappe.db.sql("""select valuation_rate
          			from `tabStock Ledger Entry`
          			where

This file has been truncated. show original