Set workflow state by javascript [Version-11]

Leonardo_Augusto · January 22, 2020, 6:16am

Can’t set workflow state by javascript anymore?
I’m getting this error after switch to version 11

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 61, in application
response = frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 21, in handle
data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 56, in execute_cmd
return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1036, in call
return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/ordem_servico/ordem_servico/ordem_servico/doctype/manutencao_externa/manutencao_externa.py", line 52, in make_maintenance
os.update_status()
  File "/home/frappe/frappe-bench/apps/ordem_servico/ordem_servico/ordem_servico/doctype/ordem_servico_externa/ordem_servico_externa.py", line 52, in update_status
self.save()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 260, in save
return self._save(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 299, in _save
self._validate()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 452, in _validate
self.validate_workflow()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 471, in validate_workflow
validate_workflow(self)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/workflow.py", line 144, in validate_workflow
WorkflowPermissionError)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 360, in throw
msgprint(msg, raise_exception=exc, title=title, indicator='red')
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 346, in msgprint
_raise_exception()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 315, in _raise_exception
raise raise_exception(msg)
frappe.model.workflow.WorkflowPermissionError: Workflow State transition not allowed from <b>Enviado</b> to <b>Agendamento Pendente</b>

Leonardo_Augusto · January 22, 2020, 3:00pm

Found it!

Commented lines 140 ~ 144

github.com

frappe/frappe/blob/version-11/frappe/model/workflow.py#L140


      
          	if current_state != next_state:
          		bold_current = frappe.bold(current_state)
          		bold_next = frappe.bold(next_state)
          
          
		if not doc._doc_before_save:
          			# transitioning directly to a state other than the first
          			# e.g from data import
          			frappe.throw(_('Workflow State transition not allowed from {0} to {1}').format(bold_current, bold_next),
          				WorkflowPermissionError)
          
          
		transitions = get_transitions(doc._doc_before_save)
          		transition = [d for d in transitions if d.next_state == next_state]
          		if not transition:
          			frappe.throw(_('Workflow State transition not allowed from {0} to {1}').format(bold_current, bold_next),
          				WorkflowPermissionError)
          
          
def get_workflow(doctype):
          	return frappe.get_doc('Workflow', get_workflow_name(doctype))
          
          
def has_approval_access(user, doc, transition):
          	return (user == 'Administrator'

The problem is that lines forces you to create a transition for all states