Rounding Off issue in Sales Return for vAT value

Chinjuprotech · May 31, 2020, 5:30am

Hi

i am facing rounding off issue while making Sales Return in VAT value not in all cases when it

Suppose Value AED 108.50, VAT 5 %= 5.425 ie, 5.43

But it is showing 5.43 , but once saving it becomes 5.42.

Kindly help

clarkej · May 31, 2020, 5:27pm

Whether to round up or down here is a ‘policy convention’ for example https://www.theproblemsite.com/ask/2018/02/rounding-05

clarkej · June 12, 2020, 2:03am

ok yes indeed the code:

github.com

frappe/frappe/blob/f70024e4b12ba4fc4d6b1cd68e282d874fc082bc/frappe/utils/data.py#L486


      
          		smallest integer greater than or equal to the given number
          
          
	"""
          	try: num = cint(math.ceil(flt(s)))
          	except: num = 0
          	return num
          
          
def cstr(s, encoding='utf-8'):
          	return frappe.as_unicode(s, encoding)
          
          
def rounded(num, precision=0):
          	"""round method for round halfs to nearest even algorithm aka banker's rounding - compatible with python3"""
          	precision = cint(precision)
          	multiplier = 10 ** precision
          
          
	# avoid rounding errors
          	num = round(num * multiplier if precision else num, 8)
          
          
	floor_num = math.floor(num)
          	decimal_part = num - floor_num

implements this https://proxy.c2.com/cgi/wiki?BankersRounding

Except the rounding algorithm applies here to real numbers (rather than integers), to a specified number of decimal digit precision