Pricing Rule is a mess on v10.x.x

aldoblack · February 25, 2019, 10:28pm

I am playing and testing with Pricing Rule and so far I can see that it is a total mess.

I am calling the Pricing Rule from this function:

frappe/erpnext/blob/v10.x.x/erpnext/accounts/doctype/pricing_rule/pricing_rule.py#L79


      
          	def validate_max_discount(self):
          		if self.price_or_discount == "Discount Percentage" and self.item_code:
          			max_discount = frappe.db.get_value("Item", self.item_code, "max_discount")
          			if max_discount and flt(self.discount_percentage) > flt(max_discount):
          				throw(_("Max discount allowed for item: {0} is {1}%").format(self.item_code, max_discount))
          
          

          
#--------------------------------------------------------------------------------
          
          
@frappe.whitelist()
          def apply_pricing_rule(args):
          	"""
          		args = {
          			"items": [{"doctype": "", "name": "", "item_code": "", "brand": "", "item_group": ""}, ...],
          			"customer": "something",
          			"customer_group": "something",
          			"territory": "something",
          			"supplier": "something",
          			"supplier_type": "something",
          			"currency": "something",
          			"conversion_rate": "something",

Every time I change, add or remove Pricing Rule it return different column names:
Check these out:

Sometimes it shows like this:

13%20PM

and sometimes like this:
47%20PM

And on Price or Discount I choose Price and put a fixed price, it returns rate 0.