Was merging the job application, couple of minor convention issues:
1. Please use tabs instead of spaces in code files :)
2. You have committed a .py~ file by mistake - just add "*~" in .gitignore so all files ending with ~ are not committed.
3. When committing changes in .txt files, the "modified" property also needs to be updated because that is how schema changes are propagated. You can just save the Communication DocType again with developer_mode =1 and it will automatically change the timestamp.
Otherwise its all set to go :)
Thanks again for contributing.. Look forward to many more collaborations!
Tabs are used infact gitignore updated communication doctype has already changes implemented and pull request is also made in wnframework as now communication is in core…
On Mon, Dec 31, 2012 at 11:13 AM, Rushabh Mehta <rm…@gmail.com> wrote:
Gowrav,
Was merging the job application, couple of minor convention issues:
1. Please use tabs instead of spaces in code files :)
2. You have committed a .py~ file by mistake - just add "*~" in .gitignore so all files ending with ~ are not committed.
3. When committing changes in .txt files, the "modified" property also needs to be updated because that is how schema changes are propagated. You can just save the Communication DocType again with developer_mode =1 and it will automatically change the timestamp.
Otherwise its all set to go :)
Thanks again for contributing.. Look forward to many more collaborations!
-------------------------------------------------------------------- Never Never Never Never Never Never Never Never Never Never Never Never Never Never Never GIVE UP
–
You received this message because you are subscribed to the Google Groups "ERPNext Developer Forum" group.
On 31-Dec-2012, at 12:34 PM, Gowrav Vishwakarma <go...@gmail.com> wrote:
:( Tabs are used infact gitignore updated communication doctype has already changes implemented and pull request is also made in wnframework as now communication is in core...
On Mon, Dec 31, 2012 at 11:13 AM, Rushabh Mehta <rm...@gmail.com> wrote:
Gowrav,
Was merging the job application, couple of minor convention issues:
1. Please use tabs instead of spaces in code files :)
2. You have committed a .py~ file by mistake - just add "*~" in .gitignore so all files ending with ~ are not committed.
3. When committing changes in .txt files, the "modified" property also needs to be updated because that is how schema changes are propagated. You can just save the Communication DocType again with developer_mode =1 and it will automatically change the timestamp.
Otherwise its all set to go :)
Thanks again for contributing.. Look forward to many more collaborations!
-------------------------------------------------------------------- Never Never Never Never Never Never Never Never Never Never Never Never Never Never Never GIVE UP
–
You received this message because you are subscribed to the Google Groups “ERPNext Developer Forum” group.
