Jquery return false not stopping form submit

Frappe Framework
1

My purpose is to stop submitting form if no attachment is attached.

$(document).ready ( function () {
   $('button[type="submit"]').on('click', function(e){
   		if ($('input[name="attach_document"]')[0].value == "" ) {
   			e.preventDefault();
   			alert("No File Attached");
   			return false;
   		}
   });
});

Please help me to find why the code doesnot work. Thanks

2

@vivin_joseph use

frappe.throw(__("Please select Company"));

3

@khushal_t Thanks…
Its not working.its showing frappe.throw is not a function

4

@vivin_joseph on which form ?

5

@khushal_t webform

6

@vivin_joseph It works within desk since it is webform you yourself need to write binding events so your code with
return false; is right you check with browser debugger where you can see each line execution you may trace something that you are missing

7

Try putting e.preventDefault();

8

@netchampfaris I have used it.

9

Do your alert box promting??

10

Sorry, missed it.

Don’t bind the event on button click, bind it when form is submitted

$('form').on('submit', function() {
    if ($('input[name="attach_document"]')[0].value == "" ) {
   		e.preventDefault();
   		alert("No File Attached");
   		return false;
   	}
})
11

@khushal_t alert box is showing and form submits

12

@netchampfaris the form again submits

13

can you show your all code ??