How to make all attachments private as default in the upload window

markgates · September 3, 2020, 8:19pm

How to make all attachments private as default in the upload window ?

ROHAN_JAIN1 · September 4, 2020, 7:05am

Hey @markgates ,

Try frappe/upload.js at 880d824b77d2a6392a5d8ae9ea7db22199513c91 · frappe/frappe · GitHub

to change the line to
file => Object.assign(file, {is_private: opts.is_private || 1})

so be default all the attachment will be made private

moe01325 · October 24, 2021, 2:14pm

Seems like the upload handling was a bit changed in latest version.

Does anybody have a tip how to default/set all upload to private?

Thanks!

PyJumper · October 24, 2021, 5:27pm

you can try adding the following to line 21 under the if block:
opts.is_private = 1;

moe01325 · October 24, 2021, 5:52pm

Seems like the current, relevant files are:
https://github.com/frappe/frappe/blob/develop/frappe/public/js/frappe/file_uploader/index.js
and

github.com

frappe/frappe/blob/develop/frappe/public/js/frappe/file_uploader/FileUploader.vue

<template>
	<div class="file-uploader"
		@dragover.prevent="dragover"
		@dragleave.prevent="dragleave"
		@drop.prevent="dropfiles"
	>
		<div
			class="file-upload-area"
			v-show="files.length === 0 && !show_file_browser && !show_web_link"
		>
			<div v-if="!is_dragging">
				<div class="text-center">
					{{ __('Drag and drop files here or upload from') }}
				</div>
				<div class="mt-2 text-center">
					<button class="btn btn-file-upload" @click="browse_files">
						<svg width="30" height="30" viewBox="0 0 30 30" fill="none" xmlns="http://www.w3.org/2000/svg">
							<circle cx="15" cy="15" r="15" fill="url(#paint0_linear)"/>
							<path d="M13.5 22V19" stroke="white" stroke-linecap="round" stroke-linejoin="round"/>
							<path d="M16.5 22V19" stroke="white" stroke-linecap="round" stroke-linejoin="round"/>

This file has been truncated. show original

So maybe this needs adaption?

github.com

frappe/frappe/blob/28fce91673c882792aea9426c915ccdc158ca7df/frappe/public/js/frappe/file_uploader/FileUploader.vue#L456


      
          					}
          				}
          				xhr.open('POST', '/api/method/upload_file', true);
          				xhr.setRequestHeader('Accept', 'application/json');
          				xhr.setRequestHeader('X-Frappe-CSRF-Token', frappe.csrf_token);
          
          
				let form_data = new FormData();
          				if (file.file_obj) {
          					form_data.append('file', file.file_obj, file.name);
          				}
          				form_data.append('is_private', +file.private);
          				form_data.append('folder', this.folder);
          
          
				if (file.file_url) {
          					form_data.append('file_url', file.file_url);
          				}
          
          
				if (file.file_name) {
          					form_data.append('file_name', file.file_name);
          				}

I’ll give it a try…

moe01325 · October 25, 2021, 5:43pm

I dont really make progress here…

even tried to set default of is_private on the File to 1. no success…

Elan_K · December 7, 2021, 4:48pm

I tried to set default of is_private to 1 on the File DocType customization and it works fine on the desktop browser but no luck on the mobile browser.

On the mobile or Tab browser, attachments are not private as default.

Any suggestion on this issue since the system behaviour changes on the layout change (desktop to mobile)?

Installed Apps

ERPNext: v12.25.0 (HEAD)
Frappe Framework: v12.22.2 (HEAD)

Elan_K · December 7, 2021, 11:35pm

Issue created on github,

https://github.com/frappe/erpnext/issues/28780

shridhar · January 24, 2022, 11:02am

Simple frappe app to make all attachments as private