Hooks events script

Leonardo_Augusto · July 20, 2017, 9:56am

Someone can help me convert this script to hooks event please?

JS:

frappe.ui.form.on("Purchase Invoice", "validate", function(frm) {
    $.each(frm.doc.parcelas || [], function(i, d) {
        // Create titulo
        frappe.call({
		method: "financeiro.financeiro.doctype.titulos.titulos.make_titulo",
		args : {
			vencimento_parcela: d.vencimento_parcela,
			valor_parcela: d.valor_parcela,
			bill_no: frm.doc.bill_no,
			posting_date: frm.doc.posting_date,
			supplier_name: frm.doc.supplier_name,
			company: frm.doc.company,
		},
        callback: function(r){}
        });
    });
});

PY:

@frappe.whitelist()
def make_titulo(vencimento_parcela, valor_parcela, bill_no, posting_date, supplier_name, company):
        titulos = frappe.new_doc("Titulos")
        titulos.naming_series = "TIT-A-PAGAR-"
        titulos.tipo_parte = "Supplier"
        titulos.tipo_documento = "Purchase Invoice"
        titulos.data_vencimento = vencimento_parcela
        titulos.valor_titulo = valor_parcela
        titulos.numero_nota = bill_no
        titulos.data_postagem = posting_date
        titulos.parte = supplier_name
        titulos.empresa = company
	    titulos.save()
        return titulos.name

saurabh6790 · July 20, 2017, 2:48am

In hooks.py

doc_events = {
	"Purchase Invoice": {
		"validate": "path_to_your_method"
	}
}

revant_one · July 20, 2017, 7:50am

Also add following in hooks,

doctype_js = {"Purchase Invoice" : "public/js/purchase_invoice_doctype.js"}

add the js code to be added on Purchase Invoice Doctype in file your_app/public/js/purchase_invoice_doctype.js

refer erpnext/hooks.py

Leonardo_Augusto · July 20, 2017, 5:11pm

I wanna pass the js code for python, so i don’t need use js anymore…

Like:

def make_titulo(vencimento_parcela, valor_parcela, bill_no, posting_date, supplier_name, company):
        for each in parcelas.idx:
             doc = frappe.get_doc("Accounts", purchase_invoice.name) 
             titulos = frappe.new_doc("Titulos")
             titulos.naming_series = "TIT-A-PAGAR-"
             titulos.tipo_parte = "Supplier"
             titulos.tipo_documento = "Purchase Invoice"
             titulos.data_vencimento = doc.due_date
             titulos.valor_titulo = doc.valor_parcela
             titulos.numero_nota = doc.bill_no
             titulos.data_postagem = doc.posting_date
             titulos.parte = doc.supplier_name
             titulos.empresa = doc.company
	         titulos.save()
             return titulos.name

That’s it?
And the hooks just:

doc_events = {
	"Purchase Invoice": {
		"validate": "titulo.make_titulo"
	}
}

revant_one · July 20, 2017, 5:42pm

Refer ERPNext hooks

doc_event hook for User doctype
Edit hooks.py of your app like this.

github.com

frappe/erpnext/blob/develop/erpnext/hooks.py#L151


	{"title": _("Shipments"), "route": "/shipments", "reference_doctype": "Delivery Note", "role":"Customer"},
	{"title": _("Issues"), "route": "/issues", "reference_doctype": "Issue", "role":"Customer"},
	{"title": _("Addresses"), "route": "/addresses", "reference_doctype": "Address"},
	{"title": _("Timesheets"), "route": "/timesheets", "reference_doctype": "Timesheet", "role":"Customer"},
	{"title": _("Timesheets"), "route": "/timesheets", "reference_doctype": "Timesheet", "role":"Customer"},
	{"title": _("Lab Test"), "route": "/lab-test", "reference_doctype": "Lab Test", "role":"Patient"},
	{"title": _("Prescription"), "route": "/prescription", "reference_doctype": "Consultation", "role":"Patient"},
	{"title": _("Patient Appointment"), "route": "/patient-appointments", "reference_doctype": "Patient Appointment", "role":"Patient"},
	{"title": _("Fees"), "route": "/fees", "reference_doctype": "Fees", "role":"Student"},
	{"title": _("Newsletter"), "route": "/newsletters", "reference_doctype": "Newsletter"},
	{"title": _("Admission"), "route": "/admissions", "reference_doctype": "Student Admission"},
	{"title": _("Certification"), "route": "/certification", "reference_doctype": "Certification Application"},
]


default_roles = [
	{'role': 'Customer', 'doctype':'Contact', 'email_field': 'email_id'},
	{'role': 'Supplier', 'doctype':'Contact', 'email_field': 'email_id'},
	{'role': 'Student', 'doctype':'Student', 'email_field': 'student_email_id'},
]


has_website_permission = {

python function which adds additional validation to User DocType
Add a function to your app’s python code like this

github.com

frappe/erpnext/blob/develop/erpnext/hr/doctype/employee/employee.py#L187


			doc.validate_employee_creation()
			doc.db_set("employee", self.name)


def get_timeline_data(doctype, name):
	'''Return timeline for attendance'''
	return dict(frappe.db.sql('''select unix_timestamp(attendance_date), count(*)
		from `tabAttendance` where employee=%s
			and attendance_date > date_sub(curdate(), interval 1 year)
			and status in ('Present', 'Half Day')
			group by attendance_date''', name))


@frappe.whitelist()
def get_retirement_date(date_of_birth=None):
	ret = {}
	if date_of_birth:
		try:
			retirement_age = int(frappe.db.get_single_value("HR Settings", "retirement_age") or 60)
			dt = add_years(getdate(date_of_birth),retirement_age)
			ret = {'date_of_retirement': dt.strftime('%Y-%m-%d')}
		except ValueError:
			# invalid date

Leonardo_Augusto · July 20, 2017, 6:10pm

I tried:

hooks.py:

docevents = "Purchase Invoice": {
      "validate": "financeiro.financeiro.doctype.titulos.titulos.make_titulo"
}

py function in titulos.py:

def make_titulo(vencimento_parcela, valor_parcela, bill_no, posting_date, supplier_name, company):
        for each in parcelas.idx:
             doc = frappe.get_doc("Accounts", purchase_invoice.name) 
             titulos = frappe.new_doc("Titulos")
             titulos.naming_series = "TIT-A-PAGAR-"
             titulos.tipo_parte = "Supplier"
             titulos.tipo_documento = "Purchase Invoice"
             titulos.data_vencimento = doc.due_date
             titulos.valor_titulo = doc.valor_parcela
             titulos.numero_nota = doc.bill_no
             titulos.data_postagem = doc.posting_date
             titulos.parte = doc.supplier_name
             titulos.empresa = doc.company
	         titulos.save()
             return titulos.name

And give me internal server error

Leonardo_Augusto · July 20, 2017, 6:16pm

Now don’t give me error, i’ll try the python script

Leonardo_Augusto · July 20, 2017, 7:41pm

My script it’s not taking arguments
I think im not getting the doc in the right way, im passing cdt(current doctype)
(Parcelas it’s a table)

def make_titulo(vencimento_parcela, valor_parcela, bill_no, posting_date, supplier_name, company):
	for parcelas in parcelas.idx:
		payment_entry = frappe.get_doc("Purchase Invoice", cdt)
        	titulos = frappe.new_doc("Titulos")
        	titulos.naming_series = "TIT-A-PAGAR-"
        	titulos.tipo_parte = "Supplier"
        	titulos.tipo_documento = "Purchase Invoice"
        	titulos.data_vencimento = purchase_invoice.parcelas.vencimento_parcela
        	titulos.valor_titulo = purchase_invoice.parcelas.valor_parcela
        	titulos.numero_nota = purchase_invoice.bill_no
        	titulos.data_postagem = purchase_invoice.posting_date
        	titulos.parte = purchase_invoice.supplier_name
        	titulos.empresa = purchase_invoice.company
		    titulos.save()
		    return

Leonardo_Augusto · July 21, 2017, 7:28pm

What i’m doing wrong? When i put the js code in Custom Script List of site this works…

Error:

Failed to load resource: the server responded with a status of 500 (INTERNAL SERVER ERROR)
desk.min.js:1402 Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 56, in application
    response = frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 21, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 52, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 920, in call
    return fn(*args, **newargs)
TypeError: make_titulo() takes at least 2 arguments (6 given)

Hooks

github.com

leonardoaugt/financeiro/blob/master/financeiro/hooks.py

# -*- coding: utf-8 -*-
from __future__ import unicode_literals
from . import __version__ as app_version

app_name = "financeiro"
app_title = "Financeiro"
app_publisher = "laugusto"
app_description = "something"
app_icon = "octicon octicon-file-directory"
app_color = "grey"
app_email = "leonardoaugt@hotmail.com"
app_license = "MIT"

doctype_js = {"Payment Entry" : "public/js/payment_entry_doctype.js",
        "Purchase Invoice" : "public/js/purchase_invoice_doctype.js"}

fixtures = [
	"Custom Script",
		{"dt":"Custom Field", "filters": [["dt", "in", ("Titulos", "Parcelas", "Payment Entry")]]}
]

This file has been truncated. show original

PY:

github.com

leonardoaugt/financeiro/blob/master/financeiro/financeiro/doctype/titulos/titulos.py#L13


# For license information, please see license.txt
from __future__ import unicode_literals
import frappe
from frappe.model.document import Document
import time


class Titulos(Document):
	pass


#Criar Titulo
@frappe.whitelist()
def make_titulo(doc_nome):
purchase_invoice = frappe.get_doc("Purchase Invoice", doc_nome)
len_array_parcelas = len(purchase_invoice.parcelas)
idx = 0
#idx irá percorrer até o total de index em tabela parcelas
for idx in range(0, len_array_parcelas):
    obj_parcelas = purchase_invoice.parcelas[idx]
    titulos = frappe.new_doc("Titulos")
    titulos.tipo_parte = "Supplier"
    titulos.tipo_documento = "Purchase Invoice"

JS:

github.com

leonardoaugt/financeiro/blob/master/financeiro/public/js/purchase_invoice_doctype.js#L1


//Validando soma de parcelas == net_total + impostos e Gerando Títulos
frappe.ui.form.on("Purchase Invoice", "before_submit", function(frm){
//Se tiver Parcelas
if (frm.doc.parcelas && frm.doc.parcelas.length > 0) {
  total_parcelas = 0;
  //Soma array parcelas
  $.each (frm.doc.parcelas || [], function(i, d){
    total_parcelas += d.valor_parcela;
  });
  total_parcelas = total_parcelas.toFixed(2);
  grand_total = frm.doc.grand_total.toFixed(2);

Leonardo_Augusto · July 21, 2017, 7:35pm

Don’t make sense call the py method by hooks event, cause the js are calling this… So how can i do this now?

Leonardo_Augusto · July 21, 2017, 7:48pm

I removed the py method of hooks and give me:
Uncaught ReferenceError: vencimento_parcela is not defined

I did not understand… if this works in Custom Script List, should be working in another place too…

SanRam · February 3, 2020, 2:15pm

Try this,

In hooks.py
doc_events = {
“Purchase Invoice”: {
“validate”: “financeiro.financeiro.doctype.titulos.titulos.make_titulo”
}
}

PY:
@frappe.whitelist()
def make_titulo(doc,method):
titulos = frappe.new_doc(“Titulos”)
titulos.naming_series = “TIT-A-PAGAR-”
titulos.tipo_parte = “Supplier”
titulos.tipo_documento = “Purchase Invoice”
titulos.data_vencimento = doc.vencimento_parcela
titulos.valor_titulo = doc.valor_parcela
titulos.numero_nota = doc.bill_no
titulos.data_postagem = doc.posting_date
titulos.parte = doc.supplier_name
titulos.empresa = doc.company
titulos.save(ignore_permissions=True)