The link if anyone is looking for this one PR. Dont know the u/passwordhttps://gh-imp-2021-00192.castlecraft.co.in/#login
got to any ready instance
click on Review Request:
Select Add Testing User:
Click on the user to see password
Moderator has to approve this request, If you do it now, I’ll approve immediately.
If you want a site for this PR then click “Request to Review” and select “Build”, It’ll be in for moderation again.
“Request to Review” button seems to be restricted to logged in users only and I am unable to sign up using email.
can you signin with google?
I’ve not set email account. I don’t wish to add my email account.
This PR was tested using the system. Now it is merged.
frappe:develop ← alyf-de:google_drive_picker
opened 05:38PM - 29 Mar 21 UTC
User can select files from Google Drive, using [Google Picker](https://developer… s.google.com/picker). The Google Drive icon is only shown if the Google integration is enabled. The behavior in the background is like attaching a URL.
<img width="1421" alt="file_uploader" src="https://user-images.githubusercontent.com/14891507/115119122-1f650100-9fa7-11eb-89f0-d089da39c1d5.png">
If it's the first time, the user needs to sign into google and / or authorize frappe to access it. The access token is saved in `frappe.boot.user.google_drive_token` so this can be skipped most of the time. Also google remembers the authorization and will skip the authorization page in the future.
<img width="1417" alt="2021-03-30 Screenshot Sign in - Google Accounts" src="https://user-images.githubusercontent.com/14891507/112914611-adfb0680-90fc-11eb-876b-feed3e502292.png">
Frappe's FileUploader is closed and instead the Google Picker appears. The user can click on a file and confirm with "Select":
<img width="1417" alt="select_a_file" src="https://user-images.githubusercontent.com/14891507/112913929-13e68e80-90fb-11eb-87a3-a29852f9844b.png">
The selected file is added as an attachment to the doc:
<img width="1415" alt="file_attached" src="https://user-images.githubusercontent.com/14891507/115119143-30ae0d80-9fa7-11eb-8b3e-5347101f086c.png">
Google Settings:
Todo:
- [x] fix file preview / failed thumbnail requests
- [x] find a way to add nice file names
- [x] use the [new google drive logo](https://developers.google.com/drive/api/v3/branding)
- [x] set picker locale according to user language
- [x] separate section in **Google Settings**?
- [x] description for fields in **Google Settings**
- [x] tests
- [x] docs
- [x] remove questionable permissions introduced with https://github.com/frappe/frappe/pull/7625
If you find this useful, you're most welcome to contribute code or money to this feature.
Picker docs: https://developers.google.com/picker/docs
Docs: https://github.com/frappe/frappe_docs/pull/109
4 Likes
The app https://github.com/revant/erpnext_feature_board is not developed any more.
Core features that it had:
build images from fork of frappe or erpnext based on PR. i.e It helps you build bench with forked frappe, erpnext and custom apps.
It deployed the images on cluster as flux/helmrelease using kubernetes api. Helm release was based on configurable helm source. i.e. It helps deploy custom benches with additional services or resources.
I extracted out the core api into separate fastapi and kopf app, It is improved and sanity tested. Hope it helps whoever wants to use it.
Potential use cases for this api and operator - build your own PR review system, SaaS sites, custom bench based PaaS.
For more: castlecraft / k8s_bench · GitLab
DO NOT use it if not familiar with Kubernetes or not already using Kubernetes.
3 Likes
