Filter is missing error

federico_calvo · May 23, 2018, 11:40am

Hello, when I apply a filter in ListView and after I go to the detail page of one of the filtered documents an error is thrown.

Thanks

Filter

Error

Julian_Robbins · May 23, 2018, 1:51pm

I get this quite a bit too. Not sure why. It doesn’t impact the application but just looks bad

lasalesi · September 6, 2018, 1:46pm

Hi all,

any updates on this? I observe this as well when opening a record in the form view (and all functionality works fine)… seen in ERPNext: v10.1.51 (master), Frappe Framework: v10.1.46 (master)

shahid · September 6, 2018, 1:57pm

Same here.

clarkej · September 6, 2018, 2:19pm

Here’s where the exception occurs…
https://github.com/frappe/frappe/blob/develop/frappe/public/js/frappe/views/reports/grid_report.js#L187

VamYip · May 10, 2019, 6:47am

We’ve been getting this error randomly and based on the wordings of error, below is the only location where it is raised.

github.com

frappe/frappe/blob/3513e6b32ddc7aaec766fd9be976d20e049eab5b/frappe/public/js/frappe/ui/filters/filters.js#L76


      
          				|| (condition==='=' && base_filter.df.condition==='like'))) {
          			// if filter exists in base_list, then exit
          			this.base_list.page.fields_dict[fieldname].set_input(value);
          
          
			return true;
          		}
          
          
		if(doctype && fieldname
          			&& !frappe.meta.has_field(doctype, fieldname)
          			&& !in_list(frappe.model.std_fields_list, fieldname)) {
          			frappe.msgprint({
          				message: __('Filter {0} missing', [fieldname.bold()]),
          				title: 'Invalid Filter',
          				indicator: 'red'
          			});
          			return false;
          		}
          
          
		this.wrapper.find('.show_filters').toggle(true);
          		var is_new_filter = arguments.length===0;

Apparently this happens when user has moved from ListView to Form(by opening one of the docs) BUT run method of ListView hasn’t finished execution. In that case, while trying to set filters based on route it gets route of a FormView whereas it expects that of a ListView. (Refer snapshot below).

I’m not sure how to solve this, but one thing to check is the call to frappe.run_serially in the call stack, which eventually triggers a ListView refresh. As synchronous AJAX calls have been deprecated, frappe.run_serially might yield before ListView refresh is complete…allowing user to go inside form view.

Regards,
Vamyip