Erpnext bench V2 https

I have managed to fight through a now fairly successful bench update to bench V2 using the troubleshooting in step 4 also in case it matters to anyone i am using Ubuntu 14.04.

The upgrade seems to have broken my https site however the http site is still working which is nice.
I read something about ngnix https in bench V2 update post

“Nginx https config auto-redirects http:// to https://”

but really have no idea what is the correct way to setup https with erpnext and just for full dis-closer before the update to bench V2 i succeed in setting up https on my site using the following instructions
https://github.com/frappe/bench/wiki/Setting-up-TLS-SSL-certificates-Let’s-Encrypt-for-Bench-sites
as per the instructions i now have this in my sites/my.domain.com/site-config.json file

“host_name”: “https://erp-2.mydomain.com”,
“ssl_certificate”: “/etc/letsencrypt/live/erp-2.mydoamain.com/fullchain.pem”,
“ssl_certificate_key”: “/etc/letsencrypt/live/erp-2.mydomain.com/privkey.pem”

NOTE i do not know if this the correct way to get https working with bench V2 and do not really like letsencrypt as i only trust myself haha

As stated above after the upgrade to bench V2 my https site is not working anymore only the http site is up. Below is the output from a bench update which contains some errors relating to python and https so maybe they have something to do with my https site not working. These errors do not appear everytime i run an update only sometimes. Anyways I googled the errors but do not want to start tweeking my OS until i hopefully receive some guidance here.

bench update
INFO:bench.utils:updating bench
Already up-to-date.
Requirement already satisfied (use --upgrade to upgrade): Pillow in ./env/lib/python2.7/site-packages
INFO:bench.app:pulling frappe
From https://github.com/frappe/frappe

  • branch master -> FETCH_HEAD
    Already up-to-date.
    INFO:bench.app:pulling erpnext
    From https://github.com/frappe/erpnext
  • branch master -> FETCH_HEAD
    Already up-to-date.
    INFO:bench.app:pulling paypal_integration
    From https://github.com/frappe/paypal_integration
  • branch master -> FETCH_HEAD
    Already up-to-date.
    /home/frappe/frappe-bench/env/local/lib/python2.7/site-packages/pip/vendor/requests/packages/urllib3/util/ssl.py:315: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subje
    ct Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. For more info
    rmation, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning.
    SNIMissingWarning
    /home/frappe/frappe-bench/env/local/lib/python2.7/site-packages/pip/vendor/requests/packages/urllib3/util/ssl.py:120: InsecurePlatformWarning: A true SSLContext object is not available. T
    his prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#inse
    cureplatformwarning.
    InsecurePlatformWarning
    Requirement already up-to-date: pip in ./env/lib/python2.7/site-packages
    Migrating erp-2.mydomain.com
    Updating frappe : [========================================]
    Updating erpnext : [========================================]

@c0mputerking

Did you run bench setup nginx after completing the installation process using bench v2 ?

Also, What error do you see while you try to open https://erp-2.mydoamain.com. This help in getting more insight in your problem.