Documentation update Sugesstion

aldoblack · August 25, 2017, 1:31pm

Yesterday I was trying to get to work with OAuth2 , and it took me all day work until to realize that I was logged in as Administrator. And you can not use OAuth logged in as Administrator.
I suggest to update the documentation here for other developers in the future ( https://frappe.io/docs/user/en/guides/integration/using_oauth )

Regards.

revant_one · August 25, 2017, 3:05pm

You can send a pull request? Doc update Pull Request is easy for everyone to try.

aldoblack · August 25, 2017, 7:20pm

Where is the file that I should change? I can not find it.

aldoblack · August 25, 2017, 8:18pm

Never mind. Found it.

revant_one · August 26, 2017, 7:27am

reference:

github.com

frappe/frappe/blob/develop/frappe/integrations/oauth2.py#L117


      
          						"client_id": frappe.db.get_value("OAuth Client", kwargs["client_id"], "app_name"),
          						"success_url": success_url,
          						"failure_url": failure_url,
          						"details": scopes,
          					}
          				)
          				resp_html = frappe.render_template(
          					"templates/includes/oauth_confirmation.html", response_html_params
          				)
          				frappe.respond_as_web_page("Confirm Access", resp_html)
          		except (FatalClientError, OAuth2Error) as e:
          			return generate_json_error_response(e)
          
          

          
@frappe.whitelist(allow_guest=True)
          def get_token(*args, **kwargs):
          	try:
          		r = frappe.request
          		headers, body, status = get_oauth_server().create_token_response(
          			r.url, r.method, r.form, r.headers, frappe.flags.oauth_credentials
          		)

revant_one · August 26, 2017, 12:00pm

@aldoblack

Try without “openid” in scope, it’ll allow Administrator