Doctype Bin Modified Timestamp

Manan_Shah · February 10, 2022, 8:03am

Does the modified field get updated in Bin Doctype on modifications?

As per the controller code in E-Commerce Integration the modified timestamp of Bin is compared with inventory_synced field to decide whether the inventory should be synced or not.

ERPNext Versions

ERPNext: v13.18.0 (version-13)
Frappe Framework: v13.18.0 (version-13)

I tried checking the modified field in database after modification in Bin (Cancellation of Sales Order>updated the Reserved and Projected Qty in Bin Doctype) but the modified field did not get updated.

Any help on this will be appreciated.

ankush · February 11, 2022, 5:12am

Looks like some updates to bin aren’t updating the modified timestamp.

github.com

frappe/erpnext/blob/c371b52d279c02af0632c9e783e45c13e30ebaac/erpnext/stock/stock_balance.py#L169-L181


      
          def update_bin_qty(item_code, warehouse, qty_dict=None):
          	from erpnext.stock.utils import get_bin
          	bin = get_bin(item_code, warehouse)
          	mismatch = False
          	for field, value in qty_dict.items():
          		if flt(bin.get(field)) != flt(value):
          			bin.set(field, flt(value))
          			mismatch = True
          
          
	if mismatch:
          		bin.set_projected_qty()
          		bin.db_update()
          		bin.clear_cache()

We can change this to update modified in all cases

created issue for this: always update bin modified timestamp · Issue #29744 · frappe/erpnext · GitHub

Manan_Shah · February 11, 2022, 5:25am

Hi Ankush,
Thanks for the reply.
I think we need to add the following line bin.modified= frappe.utils.now() below line 179 in the above code.
I tried it on my trial instance. It worked well.

Thanks

ankush · February 11, 2022, 6:32am

Fixed now. Thanks for pointing this out