Try ERPNext Try Frappe Cloud Buy Support Partners Foundation

Can no longer add favicon.ico

For months I have been using curl scripts for inserting initial data.

Now the script to supply the favicon.ico fails with:

Traceback (most recent call last):
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/app.py", line 64, in application
    response = frappe.api.handle()
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/api.py", line 58, in handle
    return frappe.handler.handle()
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/handler.py", line 30, in handle
    data = execute_cmd(cmd)
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/handler.py", line 70, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/__init__.py", line 1113, in call
    return fn(*args, **newargs)
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/client.py", line 369, in attach_file
    _file.save()
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/model/document.py", line 285, in save
    return self._save(*args, **kwargs)
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/model/document.py", line 307, in _save
    self.insert()
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/model/document.py", line 231, in insert
    self.run_method("before_insert")
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/model/document.py", line 848, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/model/document.py", line 1133, in composer
    return composed(self, method, *args, **kwargs)
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/model/document.py", line 1116, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/model/document.py", line 842, in <lambda>
    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/core/doctype/file/file.py", line 56, in before_insert
    self.save_file(content=self.content, decode=self.decode)
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/core/doctype/file/file.py", line 479, in save_file
    self.content = strip_exif_data(self.content, self.content_type)
  File "/home/erpdev/frappe-bench-DSWC/apps/frappe/frappe/utils/image.py", line 39, in strip_exif_data
    new_image.save(output, format=content_type.split('/')[1])
  File "/home/erpdev/frappe-bench-DSWC/env/lib/python3.8/site-packages/PIL/Image.py", line 2153, in save
    save_handler = SAVE[format.upper()]
KeyError: 'VND.MICROSOFT.ICON'

Anyone got any hints how to deal with this?

erpnext 13.0.0-beta.9
frappe 13.0.0-beta.9

Update: Also occurs with

erpnext 13.0.0-beta.11
frappe 13.0.0-beta.10

This also occurs when trying to upload a favicon.ico file using the File Manager

favicon.ico is for website or dashboard ??

So I tracked down this issue because it was too annoying to ignore:
(relevant for V13 only)

1 Like