[Bot] [Discussion] [PR #13605] fix: multiple form tour issues

1

Testing Site URL: https://gh-imp-2021-00419.castlecraft.co.in

Pull Request URL: https://github.com/frappe/frappe/pull/13605
Pull Request Title: fix: multiple form tour issues
Pull Request Description: - Start Form Tour only when the route is changed & the form is loaded - Look for standard tours if no tour name is provided - Initialize driver only if form-tour is initialized - Fixes a case, where signature field is not rendered on form load -

<summary>Broken Contract Form</summary>

user: rjones@velasquez.info
password: 44748e4435

3 Likes
2

Can we add the username / password for testing in this message?

3

Initial plan was to add separate user for each tester.

For volunteer testers visit here https://board.castlecraft.co.in/improvement?name=GH-IMP-2021-00419 and request to add a testing user. Admin can then add it with click of button. erpnext_feature_board/review_request.py at main · revant/erpnext_feature_board · GitHub

I added the user manually:

user: rjones@velasquez.info
password: 44748e4435

We can add public credentials? Should we?

1 Like
4

How about giving a single credential to each user that could be used in any instance?
So the login of all instances would refer the same database of credentials.

5

Anything can be done, you saw the function and if you are a developer then it can be made configurable to do anything.

6

This PR got merged. The site is now deleted.
Hopefully the PR review system is useful.

3 Likes