Multiple Custom Scripts per DocType

fahimalizain · February 14, 2017, 4:28am

Hii
Currently we can have only single Custom Script per DocType. It is fine for most of the cases.
Consider this- we extended a feature in erpnext that is a little bit big., and required by most of the customers., so instead of copying the modifications to each of the customer app, I think its best to save it as an app, so this feature can be deployed easily anywhere.

The custom scripts copied from app1 is overwritten by those from app2. This is because frappe is taking only single custom script per doctype. Currently the solution is to export customer specific code in fixtures, and manually copy paste app2’s custom script in a newline of the app1’s custom scripts, after deploying

Why didnt they do this ? development limitation ?
Or the way i am implementing the feature is wrong ?

Thanks

nabinhait · February 14, 2017, 5:39am

Instead of exporting custom script as fixture, try to create file for the custom script in the custom app.

Please check sample script and structure in the following repo.

fahimalizain · February 14, 2017, 5:42am

hi @nabinhait
On looking the fixture.py, i think it overwrites the script however I do it

github.com

frappe/frappe/blob/develop/frappe/utils/fixtures.py#L41


      
          	if os.path.exists(frappe.get_app_path(app, "fixtures", "custom_scripts")):
          		for fname in os.listdir(frappe.get_app_path(app, "fixtures", "custom_scripts")):
          			if fname.endswith(".js"):
          				with open(frappe.get_app_path(app, "fixtures", "custom_scripts") + os.path.sep + fname) as f:
          					doctype = fname.rsplit(".", 1)[0]
          					script = f.read()
          					if frappe.db.exists("Client Script", {"dt": doctype}):
          						custom_script = frappe.get_doc("Client Script", {"dt": doctype})
          						custom_script.script = script
          						custom_script.save()
          					else:
          						frappe.get_doc({"doctype": "Client Script", "dt": doctype, "script": script}).insert()
          
          

          
def export_fixtures(app=None):
          	"""Export fixtures as JSON to `[app]/fixtures`"""
          	if app:
          		apps = [app]
          	else:
          		apps = frappe.get_installed_apps()
          	for app in apps:

nabinhait · February 14, 2017, 5:44am

Yes, you are right. Can you please fix this and send a pull request?

fahimalizain · February 14, 2017, 6:01am

sure

snv · August 13, 2018, 5:09pm

Hello,

Is this issue fixed?

fahimalizain · August 14, 2018, 11:29am

No actually, we found an alternate method to fix this.
We grouped features into multiple apps.,
in each apps, we used doctype_js hook to plug in our own custom code just like Custom Scripts.