Default company should apply for new records (e.g. Sales Invoice, Journal Entry)

lasalesi · June 9, 2018, 12:48pm

Hi all,

When using a multi-company setup, the default company is defined in the global settings, e.g.:
grafik

I would assume when this is set, it would also apply to newly created records such as Journal Entry or Sales Invoice (and many more). However, even with this set, it will always use the first created company as default for new records.

My proposal is that the default company should be used for newly created records as default company. I know there are also proposals around for a user-specific default, which I also agree to.

What is the status on this? Would a pull-request be appropriate? Any workarounds (unfortunately setting the default value of the company field in the customisation does not work)?

umair · June 10, 2018, 2:46pm

Can you check if there exist any User Permission on Company for your ERPNext account? If user permission is found for the company, it will be given priority over default company defined in the Global Defaults.

lasalesi · June 10, 2018, 6:08pm

Hi @umair,

thank you for your input. The useres have access to all companies, but most documents are for the company that was created second. I have tried to add an additional, explicit user permission for company B but it did not change anything that the first created company is the default…

vrms · November 18, 2018, 3:27pm

have you found a solution for this this far @lasalesi? If so, please kindly share it here for reference.

lasalesi · November 21, 2018, 11:43am

Hi @vrms,

unfortunately so far no…

tmatteson · November 21, 2018, 6:28pm

I think a better workflow might be to change the docfields named “company” in the system to have the “remember last value” option. So you’re working in Company A for some number of transactions and then switch to Company B and it remembers that it’s company B until you change it again.
You can customize this now, but I’d be advocating for this as the default behaviors (as opposed to regularly changing a global or user default).

Edit: the memory is per-doctype, not global, so it may be a less-good solution that way.

vrms · November 21, 2018, 10:20pm

thanks for that suggestion … do you mean this?

(taken from a v11 instance [if that matters])

tmatteson · November 22, 2018, 12:51am

Yeah it does matter, it looks like it’s not available in the docfield dialog in V11, but is in V10

The concept is simple enough: the field is memorized and available in a javascript object.

github.com

frappe/frappe/blob/bd5c27a30f00f7eba6adabef048d1794b69ca562/frappe/public/js/frappe/form/controls/link.js#L243


      
          
          
			if(item.action) {
          				item.value = "";
          				item.action.apply(me);
          			}
          
          
			// if remember_last_selected is checked in the doctype against the field,
          			// then add this value
          			// to defaults so you do not need to set it again
          			// unless it is changed.
          			if(me.df.remember_last_selected_value) {
          				frappe.boot.user.last_selected_values[me.df.options] = item.value;
          			}
          
          
			me.parse_validate_and_set_in_model(item.value);
          		});
          
          
		this.$input.on("awesomplete-selectcomplete", function(e) {
          			var o = e.originalEvent;
          			if(o.text.value.indexOf("__link_option") !== -1) {
          				me.$input.val("");

lasalesi · November 22, 2018, 8:47pm

Maybe I see this wrong, but “Track changes” on DocType “Company” means that the system will keep track of the changes of a record (history).

“Remember last selected value” on the attribute “company” in e.g. DocType “Sales Invoice” would subjectively try to remember the last value. Which would resolve the initial issue, and I can confirm the function is there in v10 (very odly translated )… will give this a try… thanks for sharing!

tmatteson · November 23, 2018, 12:03am

“Track Changes” shows the changes below the comment field, nowhere else. It is doctype specific.