Add fields to Sales Invoice Timesheets

bedo · June 26, 2017, 11:57am

I’m unable to link extra fields to sales invoice timesheets.

How do I link for example ‘task_name’ from timesheet detail?

Any help really appreciated.

rohit_w · June 26, 2017, 12:17pm

Hi @bedo

Check below code, you need to pass the extra parameter in the dictionary

github.com

frappe/erpnext/blob/develop/erpnext/projects/doctype/timesheet/timesheet.py#L318-L330


      
          		condition = "and tsd.project = %(project)s"
          
          
	return frappe.db.sql(
          		"""select distinct tsd.parent from `tabTimesheet Detail` tsd,
          			`tabTimesheet` ts where
          			ts.status in ('Submitted', 'Payslip') and tsd.parent = ts.name and
          			tsd.docstatus = 1 and ts.total_billable_amount > 0
          			and tsd.parent LIKE %(txt)s {condition}
          			order by tsd.parent limit %(page_len)s offset %(start)s""".format(
          			condition=condition
          		),
          		{
          			"txt": "%" + txt + "%",

bedo · June 26, 2017, 12:48pm

hi @rohit_w,

that code seems to run on a server side as python? So are you suggesting modifying source code? I would like to resolve my problem using custom script.

Is there an option how to fetch extra child fields without changing the source code?

rohit_w · June 26, 2017, 12:55pm

Hi @bedo

For custom script, you need to use frappe.client.get_value. For more details kindly refer below code

bedo · June 26, 2017, 1:06pm

Hi @rohit_w,
could you help me a bit with the code?
this doesn’t work…but it can’t be too far

frappe.ui.form.on("Sales Invoice", "time_sheet", function(frm) {
var child = locals[cdt][cdn];
    cur_frm.call({
        "method": "frappe.client.get_value",
        "args": {
            "doctype": "Timesheet Detail",
            "filters": {
                "name":  child.task_name
            }
        },
        "child": child,
        "fieldname": "task_name"

});

rohit_w · June 27, 2017, 10:27am

Instead of this use “parent”: child.time_sheet and you also required one more filter of the child table

bedo · June 27, 2017, 11:35am

Dear @rohit_w,

I don’t fully understand how this code should work. In its current form it throws an error.

frappe.ui.form.on("Sales Invoice", "onload", function(frm, cdt, cdn) {
var child = locals[cdt][cdn];
    frappe.call({
        "method": "frappe.client.get_value",
        "args": {
            "doctype": "Timesheet Detail",
            "filters": {
                "parent": child.time_sheet
            }
        },
        "child": child,
        "fieldname": "task_name"
	})
});

I’ve also found this piece of code, but it doesn’t work either:

github.com

frappe/erpnext/blob/develop/erpnext/accounts/doctype/sales_invoice/sales_invoice.js#L532-L554


      
          cur_frm.fields_dict.write_off_account.get_query = function(doc) {
          	return{
          		filters:{
          			'report_type': 'Profit and Loss',
          			'is_group': 0,
          			'company': doc.company
          		}
          	}
          }
          
          
// Write off cost center
          //-----------------------
          cur_frm.fields_dict.write_off_cost_center.get_query = function(doc) {
          	return{
          		filters:{
          			'is_group': 0,
          			'company': doc.company
          		}
          	}
          }

This file has been truncated. show original

I thought I could just change ‘Sales Invoice Timesheet’ to ‘Sales Invoice’ and instead of:

{
data = r.message;
frappe.model.set_value(cdt, cdn, "billing_hours", data.billing_hours);
frappe.model.set_value(cdt, cdn, "billing_amount", data.billing_amount);
frappe.model.set_value(cdt, cdn, "timesheet_detail", data.timesheet_detail);
calculate_total_billing_amount(frm)
}

I tried:

{
data = r.message;
frappe.model.set_value(cdt, cdn, "task_name", data.task_name);
}

But nothing gives me any results:( I’m hopeless…
I put this field in Sales Invoice Timesheet using Customize Form:

and this one is in Timesheet Detail:

I don’t know what I’m doing wrong.